The changes you have done to the files in tools/sdk/chip/... can not be done in this repository. Files in that folder come from ESP-IDF or one of it's external components (esp-rainmaker in this case). You can either make a pull request to the proper repository or add the definitions in the Arduino rainmaker headers.

Hi @me-no-dev!
Thanks for the review and feedback.
Yes, I was not sure about these files.

I don't know exactly how the workflow is from the ESP-IDF or Rainmaker repository to the arduino-esp32 repository.
To avoid code duplication and possible errors I think to do a pull request in the Rainmaker repository first.

Can this current pull request stay until the changes are applied to the Rainmaker / ESP-IDF repository, or is there a better way?

yup :) I've turned it into draft for now.

For tracking: PR in espressif/esp-rainmaker#126

Hi @me-no-dev The PR in espressif/esp-rainmaker#126 has been merged.
What are the next steps to bring these changes to the arduino-esp32 repository?

Hi @sivar2311, thanks for letting me know. I have updated the lib-builder and generated the new libs. They are currently here and will soon be merged into master in preparation for 2.0.4 release. Please revert the changes to the headers in the "sdk" folder of this pull request as those will now come from the component itself through the lib builder. Also please squash the commits. I will run CI and merge as soon as we merge the IDF updates.

Hi @me-no-dev !
Thanks for the info. I will make the necessary changes as soon as possible.

Off-topic:
The whole construct from ESP-IDF to Arduino ESP32 is still very complex and obscure for me. Are there detailed descriptions or instructions that explain the relationships and processes? I would like to go deeper into the matter and contribute more.

This repository contains the ESP-IDF project and scripts that build ESP-IDF, collect and copy everything necessary to Arduino: https://github.com/espressif/esp32-arduino-lib-builder

@me-no-dev Thanks for the information about the esp32-arduino-lib-builder.
I have now reverted the changes to the header files from the "sdk" folder.

@sivar2311 note that the target branch has changed to idf-release/v4.4, because that is where your changes are :)

@me-no-dev

your function declaration does not match the implementation. In the implementation you have two arguments: const char **string_list, uint8_t count. Probably you missed the second one.

Sorry for the inconvenience, this is embarrassing.
I saw the error message yesterday but I was already in bed.

I already had the error during development and I had already fixed it - but probably only in my local platform directory (PlatformIO) which is used for the build process. Unfortunately I was not able to get PlattformIO to use my local copy of the Arduino-ESP32 repository for the build process.

I have fixed the bug in #0cb567d

note that the target branch has changed to idf-release/v4.4, because that is where your changes are :)

Okay, that makes sense :) Do I need to change anything on my side?

Seems you have some other errors: https://github.com/espressif/arduino-esp32/runs/6875362072?check_suite_focus=true#step:5:164

Okay, that makes sense :) Do I need to change anything on my side?

No, you should be ok as-is, just make sure you have updated your fork

The definition was missing for the ESP32C3 target. This is fixed now in #de53f6f
Next time I will set up a better test suite that compiles and tests for all targets.

Thanks for your patience :)

@sivar2311 everything looks good now :) will merge before 2.0.4 release

Yeayyy
Thank you very much! Also for the support.
I'll try my best to do better next time :)